gadget hdf: reduce size 1 header arrays to scalar #4414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishavlin
added
enhancement
|
oops, look like I didn't properly exclude the new test from nose... |
Co-authored-by: Clément Robert <cr52@protonmail.com>
neutrinoceros
previously approved these changes
Jun 17, 2023
jzuhone
previously approved these changes
Jun 20, 2023
Co-authored-by: Clément Robert <cr52@protonmail.com>
neutrinoceros
approved these changes
Jun 20, 2023
|
let's try backporting this |
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one way to fix an issue reported on slack by Ben Oppenheimer: the CAMELS Astrid (Gadget-3, HDF) simulations have some hdf5 attributes saved as single element arrays but yt expects scalars, which leads to errors on dataset initialization.
The fix here simply reduces length 1 arrays to scalar values in the base gadget class.
Note that this particular flavor of HDF5 Gadget output does not have a dedicated frontend in yt. Assuming all the yt tests pass (Ben confirmed it does indeed allow loading of data and outputs from analysis seem correct), the fix here is simple enough that it seemed worth submitting even though a new frontend is a better long term solution. I also don't have a good datafile for testing, so just mocked up a header with nested arrays in the new test that I added.